No Outlook destination on Windows 10 with Office 2019 / Office365

I can confirm that Jens Klingen’s May 7, 2019, 6:23 PM post sends to Outlook 2019 successfully as a custom destination:

/a “{0}“

I suppose now Outlook only needs to be auto detected. Thank’s so much!

Hi Robin,

Many thanks for providing these instructions.

If you’ve correctly received my pull request then I was able to correctly follow your instructions!

Thanks again for allow me to make this change.

Although my change is rather insignificant I’m pleased that I’ve managed to make a change [albeit minor] to a great application. Thank you.

Lee

Really great that you are trying this!!

In general, for every project on github or similar platforms, the workflow is:

• Fork the project, this will make a copy with all the modification rights under your own profile. This is important as you don’t have permissions to change anything to someones repository if you are no contributor. Which is good, you would be able break or disturb their work…

• Make the changes in the correct branch, for Greenshot this is currently develop. (Master would be for fixes in the current Greenshot version which you can download and install)

  • If you want to use a more professional workflow you can create a branch for your changes, with names like bugfix/BUG-2240 or feature/FEATURE-1234.

  • There are also some guidelines for the code formatting & style.. I need to work on that.

• Commit & Push the changes to YOUR repository

• Make a pull request to the repository, in our case to the Greenshot develop branch, explaining what you did.

• The repository maintainer, for Greenshot this can be me or my colleagues, will look at it and merge the changes into the code, than the PR is closed.

  • When you create the pull-request, for Greenshot a build is started where we can see if the changes don’t break our code. This will be marked in the PR. Sometimes other processes are triggered, like a Contributor License Agreement assistant but I don’t have it in place YET.

Hope this helps!!!

I hope to free up some time for the process soon, and make it easier to contribute. So it would be nice if you feel like doing more than this, and I could support you → making documentation along the way

But if not, that is okay too!!!!!!

Hi Robin, many thanks for the offer - I’d love to have a go at fixing this. I have only had experimental attempts at making changes on GitHub. So, I’m a little out of my depth here…but I’d love to have a go.

I have tried and I am not having much success. I have ‘cloned’ a copy of the source to my workstation and I have created a new branch to make my changes. I have made my changes and then I typed…

git push --set-upstream origin develop

…because it appears to me that ‘develop’ is the master (…I tried “…origin master” too). I receive the following response…

remote: Permission to greenshot/greenshot.git denied to leewilmott.
fatal: unable to access ' The requested URL returned error: 403

What am I doing wrong? Please help!

Many thanks, Lee

yes, don’t know what happened… maybe my dog wanted to code too. The @ symbol shouldn’t be there either, although that doesn’t make a difference.

I haven’t gone through testing yet, usually we place the Jira on solved after we test and not after we finish coding, so I would have found it at that point. But this does save me a lot of time, thanks!

As you are looking at the code, do you know how to fix this and make a Pull-Request on GitHub?
Maybe you want the honors so you can say, you fixed a bug in Greenshot

I still expect issues with the icons though, if I can’t find the executables, I cannot find the icons either…